-
-
Notifications
You must be signed in to change notification settings - Fork 234
PR: Add universal screw parameters to screws_tilt_adjust with backward compatibility #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GiacomoGuaresi
wants to merge
27
commits into
KalicoCrew:main
Choose a base branch
from
gingeradditive:configurable-screw-for-tilt-adjust
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+342
−6
Open
Changes from 12 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fdf1524
feat: Add `screw_factor` and `screw_direction` options
GiacomoGuaresi 49fde13
chore: Clean up whitespace and line breaks in screws_tilt_adjust.py
GiacomoGuaresi bb98415
docs: Add detailed explanation for `screw_factor` in screws_tilt_adjust
GiacomoGuaresi 32fd2d9
test: Add comprehensive unit tests for screws_tilt_adjust
GiacomoGuaresi c1f3135
refactor: Rename `screw_factor` to `screw_pitch` for clarity
GiacomoGuaresi a92906c
docs: Simplify `screw_direction` description in screws_tilt_adjust
GiacomoGuaresi 1deb78f
refactor: Use `getchoice()` for `screw_direction` validation
GiacomoGuaresi 669b96c
refactor: Extract screw thread mapping to module-level constant
GiacomoGuaresi 90acb6b
refactor: Make `screw_thread` lookup case-insensitive
GiacomoGuaresi 054081d
docs: Remove default values for `screw_pitch` and `screw_direction`
GiacomoGuaresi 6cfdc0c
refactor: Format `screw_direction` getchoice call for readability
GiacomoGuaresi 122674a
refactor: Defer `screw_direction` validation until after `screw_threa…
GiacomoGuaresi 2341eb6
Update docs/Config_Reference.md
GiacomoGuaresi 34aa908
chore: Consolidate screw configuration validation logic
GiacomoGuaresi 31a1641
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi c8293e1
chore: update the docs
GiacomoGuaresi a0628be
refactor: Replace screw thread map with indexed lookup table
GiacomoGuaresi c137209
refactor: Replace screw_thread map with indexed lookup and manual val…
GiacomoGuaresi 8508b0c
refactor: Move screw_thread validation to use getchoice with default …
GiacomoGuaresi 93b500c
refactor: Simplify screw configuration validation logic with explicit…
GiacomoGuaresi e9a4c9e
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi 01919e4
style: Apply consistent code formatting in screws_tilt_adjust module
GiacomoGuaresi db2b104
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi 2270664
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi d87e749
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi 9412eb5
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi 25d755a
Merge branch 'main' into configurable-screw-for-tilt-adjust
GiacomoGuaresi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.