[iibaranov-IG]

Summary

• cover camera profile create/read/update/delete across a service restart using a persistent temporary Data Protection key ring
• prove plaintext passwords never reach camera-profiles.json and password-preserve/clear semantics stay intact
• protect the immutable demo profile against mutation through both read APIs
• reject malformed explicit IDs, ignore malformed persisted IDs, and verify undecryptable secrets fail closed without leaking into warnings
• clean all isolated camera data and keys after each test

Verification

• dotnet test IPCamLapse.sln -c Release: 110 tests pass (63 IPCamLapse + 47 OpenCamInterop)
• dotnet format IPCamLapse.sln --verify-no-changes --no-restore: pass
• git diff --check: pass
• signed commit: 5b564ac

Closes #28.

[elkampu]

The suite is strong overall, but one security acceptance case is not fully exercised.

At IPCamLapse.Tests/CameraProfileServiceTests.cs:194-208, RecordingLogger discards the Exception argument. The assertions at lines 149-151 therefore prove only that the message template omits the stored value, not that the complete warning a provider emits omits it. Please capture/assert the full rendered record, including exception text. While touching this test, an explicit non-null profile assertion after clearing the secret would make the clear-vs-delete result unambiguous.

[iibaranov-IG]

Good catch — agreed. The exception cannot be allowed to enter through the side door while the message template passes inspection. I’ll update the recording logger to retain the complete rendered record, assert that the stored secret is absent from exception text as well, and add the explicit non-null profile assertion after clearing the secret.

[elkampu]

Re-reviewed at exact head 7097f29 after the normal base update. The recording logger now retains the complete emitted record and exception, the undecryptable-secret case asserts both paths, and the clear-secret test proves the profile remains present. Independent validation passed locked restore, Release build with zero warnings/errors, all 119 combined tests (72 IPCamLapse + 47 embedded OpenCamInterop), formatting, dependency audit, and diff checks. All five current GitHub checks pass.