This repository was archived by the owner on Oct 1, 2026. It is now read-only.
Repository navigation
Fix recurring windows across repeated-hour gaps - #61
Merged
Merged
Conversation
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the daily/weekly recurring-window evaluation after the contributor schedule integration in #59. On the fall-back day, a 00:30–01:15 window was incorrectly active at the first 01:30: the two occurrences of the 01:15 end had been joined into one continuous UTC interval. A 01:45–02:15 window had the corresponding repeated pre-start gap.
The evaluator now splits those windows at the actual time-zone offset transition, preserving the first and second valid segments without marking the intervening wall-clock gap active. It ignores a zero-length second segment when an end falls exactly on the transition. No persisted schedule contract or time-zone selection changes.
Verification
NextStartUtc.dotnet restore IPCamLapse.sln --locked-mode: pass.dotnet build IPCamLapse.sln -c Release --no-restore: zero warnings/errors.dotnet test IPCamLapse.sln -c Release --no-restore: 176 passed, none skipped.dotnet format IPCamLapse.sln --verify-no-changes --no-restoreandgit diff --check: pass.Refs #33. Keep #33 open until the integrated behavior and linked-issue state are rechecked after this fix merges.