Fix encoded glyph paths for object storage - #236
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 51.98% 56.39% +4.41%
==========================================
Files 27 28 +1
Lines 629 633 +4
Branches 163 163
==========================================
+ Hits 327 357 +30
+ Misses 261 238 -23
+ Partials 41 38 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kanahiro
marked this pull request as ready for review
August 18, 2026 15:03
BenchmarkComparison:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
MapLibre Native percent-encodes
{fontstack}before passing glyph URLs to the source resolver. S3 and GCS treated that encoded value as a literal object key, so font stacks containing spaces or commas could not be found.Decoded paths are attempted first because they are the normal MapLibre glyph case and avoid an extra not-found request for every glyph range. Literal encoded keys remain available as a fallback.
Validation
npm run checknpm run test:unit -- --run(42 tests passed)git diff --checkCloses #235