Support NetBox 4.6 (issue #103)#104
Conversation
Allows installing the plugin on NetBox 4.6.x. Pre-release for compatibility testing before a final 11.2.0.
README, compatibility.md, and installation.md now reflect the 4.5.x – 4.6.x supported range matching __init__.py max_version=4.6.99.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
96-98:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winConsider adding link references for recent versions.
The link reference section at the bottom includes entries for
[11.0.1],[11.0.0], and[10.0.0], but is missing references for[11.2.0b1]and[11.1.0]that appear in the changelog body. Adding these would improve navigation consistency.📎 Proposed fix to add missing link references
+[11.2.0b1]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.2.0b1 +[11.1.0]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.1.0 [11.0.1]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.0.1 [11.0.0]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.0.0 [10.0.0]: https://github.com/Kani999/netbox-attachments/releases/tag/v10.0.0🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG.md` around lines 96 - 98, The CHANGELOG.md link reference section is missing entries for versions referenced in the body; add link references for [11.2.0b1] and [11.1.0] to match the existing pattern (e.g., [11.2.0b1]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.2.0b1 and [11.1.0]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.1.0) so the in-text links resolve correctly; update the block containing [11.0.1], [11.0.0], [10.0.0] in CHANGELOG.md to include these two new reference lines.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@CHANGELOG.md`:
- Around line 96-98: The CHANGELOG.md link reference section is missing entries
for versions referenced in the body; add link references for [11.2.0b1] and
[11.1.0] to match the existing pattern (e.g., [11.2.0b1]:
https://github.com/Kani999/netbox-attachments/releases/tag/v11.2.0b1 and
[11.1.0]: https://github.com/Kani999/netbox-attachments/releases/tag/v11.1.0) so
the in-text links resolve correctly; update the block containing [11.0.1],
[11.0.0], [10.0.0] in CHANGELOG.md to include these two new reference lines.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 199ed10c-1356-4e81-bb6d-48b133e7dbf7
📒 Files selected for processing (6)
CHANGELOG.mdREADME.mddocs/compatibility.mddocs/installation.mdnetbox_attachments/__init__.pynetbox_attachments/version.py
Summary
max_versionfrom4.5.99→4.6.99innetbox_attachments/__init__.pyso the plugin loads on NetBox 4.6.x (fixes Support for NetBox v4.6.0 #103).11.1.0→11.2.0b1(PEP 440 beta) and adds aCHANGELOG.mdentry.README.md,docs/compatibility.md, anddocs/installation.mdto the new4.5.x – 4.6.xrange.Tagged as
v11.2.0b1for beta testing on NetBox 4.6 before a final11.2.0release.Test plan
UserWarning: ... requires NetBox maximum version 4.5.99from Support for NetBox v4.6.0 #103 is gone, plugin loads.make testpasses locally.Summary by CodeRabbit
New Features
Documentation