Fixes #38938 - Add containerfile-install-command #1017
Conversation
chris1984
left a comment
chris1984
left a comment
There was a problem hiding this comment.
Have not tested, code looks good
qcjames53
left a comment
qcjames53
left a comment
There was a problem hiding this comment.
Hey Pavan. This works pretty well! I have a few suggestions surrounding flavor but nothing that changes your core functionality here.
pavanshekar
force-pushed
the
issue-38938
branch
from
5aabdfd to
9bec932
Compare
pavanshekar
changed the title
|
I have made the suggested changes and pushed the updated code |
qcjames53
left a comment
qcjames53
left a comment
There was a problem hiding this comment.
Your PR looks great to me. It works/fails correctly for many repos, no repos, missing hosts, and server errors. Approving.
While testing this, I also uncovered a bug with the API where only the first 20 repos are returned. I think this is my fault to be honest. I have full confidence your hammer command can handle 1000 repos no problem.
|
Looks good to me, will let @ianballou do a final look and merge |
ianballou
left a comment
ianballou
left a comment
There was a problem hiding this comment.
Small wording change to keep things consistent , looking good otherwise!
| end | ||
|
|
||
| class ContainerfileInstallCommand < HammerCLIKatello::Command | ||
| desc _("Generate a Containerfile RUN command from transiently installed packages on image-mode hosts") |
There was a problem hiding this comment.
| desc _("Generate a Containerfile RUN command from transiently installed packages on image-mode hosts") | |
| desc _("Generate a Containerfile RUN command from transiently installed packages on image mode hosts") |
There was a problem hiding this comment.
I have implemented the suggested changes.
pavanshekar
force-pushed
the
issue-38938
branch
from
9bec932 to
5838701
Compare
4 participants
Added a new Hammer CLI command to generate Containerfile RUN commands from a host's transiently installed packages for bootc/image-mode systems.