fix: removed some unused imports #167
Closed
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris1984
approved these changes
Apr 10, 2025
Member
chris1984
left a comment
chris1984
left a comment
There was a problem hiding this comment.
Looks fine to me, @ianballou want to have a look?
ekohl
reviewed
Oct 5, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
The redundant imports all look correct and the whitespace changes too, but with changing the function signatures I have some doubts.
pr-processor
bot
added
Waiting on contributor
Needs re-review
and removed
Needs re-review
labels
bevel-zgates
force-pushed
the
fix/unused-imports
branch
from
cedd170 to
80bd876
Compare
bevel-zgates
force-pushed
the
fix/unused-imports
branch
from
80bd876 to
2f8cbca
Compare
fix(revert): removed body -> _body change for unused param fix(revert): Remove Underscored prefix for unused params
bevel-zgates
force-pushed
the
fix/unused-imports
branch
from
2f8cbca to
446d2a7
Compare
Author
|
Doesn't look like there's too much activity here for reviews. Just going to close this for now to get it off my backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was taking a look at the implementation and corrected a few syntax/lint findings. Feel free to close if not helpful.