Skip to content

Conversation

@MariaAga
Copy link
Contributor

@MariaAga MariaAga commented Jul 22, 2025

relates to theforeman/foreman#10620
we want to remove the react-ellipsis-with-tooltip package

Summary by Sourcery

Remove the react-ellipsis-with-tooltip package by updating the ellipsis cell formatter to use PatternFly's Truncate component.

Enhancements:

  • Replace EllipsisWithTooltip with PatternFly's Truncate component in ellipsisCellFormatter

Chores:

  • Remove react-ellipsis-with-tooltip dependency usage

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 22, 2025

Reviewer's Guide

This PR replaces the use of the deprecated react-ellipsis-with-tooltip package in the pf3 table ellipsis cell formatter with PatternFly React’s Truncate component by updating imports and JSX usage accordingly.

Class diagram for updated ellipsisCellFormatter usage

classDiagram
    class ellipsisCellFormatter {
        +cellFormatter(value)
    }
    class Truncate {
        +content
    }
    ellipsisCellFormatter --> Truncate : uses
Loading

File-Level Changes

Change Details Files
Replace EllipsisWithTooltip with PatternFly Truncate component
  • Remove import of react-ellipsis-with-tooltip
  • Add import for Truncate from @patternfly/react-core
  • Update JSX to use Truncate with content prop instead of wrapping children
webpack/components/pf3Table/formatters/ellipsisCellFormatter.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MariaAga - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga !

I see tests have passed, so ACK

@jeremylenz jeremylenz merged commit 295ed1c into Katello:master Jul 22, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants