-
Notifications
You must be signed in to change notification settings - Fork 303
Fixes #38905 - Add ACS for Deb Repositories #11567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hstct
wants to merge
3
commits into
Katello:master
Choose a base branch
from
ATIX-AG:add-debian-acs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5397ab9 to
2cb150a
Compare
c4d381d to
feb2440
Compare
11 tasks
feb2440 to
d684c39
Compare
| param :description, String, desc: N_("Description for the alternate content source"), required: false | ||
| param :base_url, String, desc: N_('Base URL for finding alternate content'), required: false | ||
| param :subpaths, Array, desc: N_('Path suffixes for finding alternate content'), required: false | ||
| param :deb_releases, String, desc: N_('Debian releases/distributions (e.g., bookworm, bullseye)'), required: false |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| param :deb_releases, String, desc: N_('Debian releases/distributions (e.g., bookworm, bullseye)'), required: false | |
| param :deb_releases, String, desc: N_('Debian releases/distributions (e.g., trixie, bookworm)'), required: false |
suggestion to use latest two codenames as example.
Contributor
|
Just adding some ToDo reminders for ourselves:
|
Contributor
Author
|
once pulp_deb |
This will be needed as soon as the following is merged: Katello#11571
d684c39 to
1e92c73
Compare
Fix assertion. We changed the naming of Deb fields like Distributions some time before merging and this wasn't adapted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
distributionsparameter. So it has been added to the creation process.componentsandarchitecturesfields have been included to match sync.subpathsparameter and is not used by debian ACS.What are the testing steps for this pull request?
Summary by Sourcery
Add full Debian content support for Alternate Content Sources by extending the database schema, model validations, API, UI wizard, and Pulp3 orchestration workflows, accompanied by extensive test coverage.
New Features:
Enhancements:
Tests: