Skip to content

Conversation

@qcjames53
Copy link
Contributor

@qcjames53 qcjames53 commented Dec 2, 2025

What are the changes introduced in this pull request?

Fixes an issue uncovered in #11583

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Pull this PR and this hammer-cli-katello PR for your hammer environment.
  2. Verify hammer host package list --host-id <id> --order 'persistence ASC' works.
  3. Verify hammer host package list --host-id <id> --search 'persistence = transient' works.

Summary by Sourcery

Bug Fixes:

  • Correct persistence field scoped search completion mapping for host installed packages to resolve incorrect or missing matches.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working!

[vagrant@centos9-hammer-devel ~]$ hammer host package list --host-id 1 --search "persistence = transient"
-------------------------------------------------------------|------------
NVRA                                                         | PERSISTENCE
-------------------------------------------------------------|------------
aardvark-dns-1.14.0-1.el10.x86_64                            | transient  
bash-completion-2.11-16.el10.noarch                          | transient  
bind-libs-9.18.33-4.el10_0.x86_64                            | transient 

Also this works, for future reference:

hammer host package list --host-id 5 --search "NOT has persistence"
--------------------------------------------------------------|------------
NVRA                                                          | PERSISTENCE
--------------------------------------------------------------|------------
aardvark-dns-1.12.2-2.fc41.x86_64                             |            
abattis-cantarell-vf-fonts-0.301-13.fc41.noarch               |            

@ianballou ianballou merged commit adbb150 into Katello:master Dec 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants