[WIP] Does the Generate Host Applicability event need to be retryable? #11599
+3
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
I'm looking into simplifying the Event Queue starting with the retry capability that I added for a particular scenario way back. Perhaps it can go away. Since then, two events have been added which seem to use the retry-ability.
Starting with Generate Host Applicability I see:
katello/app/models/katello/events/auto_publish_composite_view.rb
Lines 22 to 31 in 2915610
linkhowever no action_subject is specified and in that case I don't think any locking or linking would occur. This needs confirmation from an expert.Considerations taken when implementing this change?
What are the testing steps for this pull request?
Summary by Sourcery
Remove unused retry and locking behavior from host applicability generation to simplify the event processing.
Enhancements: