Skip to content

Conversation

@jturel
Copy link
Member

@jturel jturel commented Dec 19, 2025

What are the changes introduced in this pull request?

I'm looking into simplifying the Event Queue starting with the retry capability that I added for a particular scenario way back. Perhaps it can go away. Since then, two events have been added which seem to use the retry-ability.

Starting with Generate Host Applicability I see:

  1. There is a "copy/paste" vibe to the event implementation. See similarities to AutoPublishCompositeView:
    begin
    ForemanTasks.async_task(::Actions::Katello::ContentView::Publish,
    composite_view,
    metadata[:description],
    triggered_by: metadata[:version_id])
    rescue => e
    self.retry = true if e.is_a?(ForemanTasks::Lock::LockConflict)
    deliver_failure_notification
    raise e
    end
  2. The action for bulk generation specified 'resource_lock' of link however no action_subject is specified and in that case I don't think any locking or linking would occur. This needs confirmation from an expert.
  3. Given 2, I don't believe the rescue ever fires and therefore the retry function would never come into play
  4. Neither event nor action have any tests that might shed light on the intention :(

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Remove unused retry and locking behavior from host applicability generation to simplify the event processing.

Enhancements:

  • Simplify GenerateHostApplicability event by removing retry handling logic around bulk host applicability generation.
  • Remove unused resource lock configuration from the bulk host applicability generation action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant