Skip to content

Conversation

@stejskalleos
Copy link
Contributor

@theforeman-bot
Copy link

Issues: #32841

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, another complication: the RHSM port is 8443 on Pulp mirrors. I really think #9413 (which implements it as a function on the Smart Proxy) is better. For reference, the relevant bit:

      def rhsm_url
        # TODO: We shouldn't relate this to the Pulp feature and also expose it
        # as a setting
        if pulp_mirror?
          "https://#{URI.parse(url).host}:8443/rhsm"
        elsif pulp_primary?
          "https://#{URI.parse(url).host}/rhsm"
        end
      end

Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments on code style but testing in conjunction with the Foreman PR works well. Here's the resulting bits from my rhsm.conf:

hostname = centos7-katello-devel.jturel.example.com
prefix = /rhsm
port = 443
[rhsm]
# Content base URL:
baseurl = https://centos7-katello-devel.jturel.example.com/pulp/content

@stejskalleos stejskalleos force-pushed the ls/rhsm_url branch 2 times, most recently from 8e6f616 to 4c2bd18 Compare July 7, 2021 11:51
Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ

@jturel
Copy link
Member

jturel commented Jul 7, 2021

[test katello]

@jturel jturel merged commit e677f20 into Katello:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants