Skip to content

Cert authenticated flatpak #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjha4 merged 1 commit into from
Jul 17, 2025
Merged

Cert authenticated flatpak #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 34 additions & 18 deletions lib/smart_proxy_container_gateway/container_gateway_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

module Proxy
module ContainerGateway
# rubocop:disable Metrics/ClassLength
class Api < ::Sinatra::Base
include ::Proxy::Log
helpers ::Proxy::Helpers
Expand All @@ -21,25 +22,32 @@ class Api < ::Sinatra::Base
inject_attr :container_gateway_main_impl, :container_gateway_main

get '/index/static/?' do
# TODO: filter out repositories that are not tied to the (optional) authenticated host
# host = <lookup host>
# catalog = host_catalog(host)

# pulp_response = container_gateway_main.flatpak_static_index(translated_headers_for_proxy, params)
# if pulp_response.code.to_i >= 400
# status pulp_response.code.to_i
# body pulp_response.body
# end

# pulp_index = JSON.parse(pulp_response.body)
# pulp_index["Results"].select! { |result| catalog.include?(result["Name"]) }

# status 200
# body pulp_index.to_json
client_cert = ::Cert::RhsmClient.new(cert_from_request) if valid_cert?
valid_uuid = client_cert&.uuid&.present?

pulp_response = container_gateway_main.flatpak_static_index(translated_headers_for_proxy, params)
status pulp_response.code.to_i
body pulp_response.body

if pulp_response.code.to_i >= 400
status pulp_response.code.to_i
body pulp_response.body
elsif valid_uuid
host = database.connection[:hosts][{ uuid: client_cert.uuid }]
if host.nil?
repo_response = ForemanApi.new.fetch_host_repositories(client_cert.uuid, request.params)
Copy link
Member

@ianballou ianballou Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add some error checking for the ForemanApi call.

Suggested change
repo_response = ForemanApi.new.fetch_host_repositories(client_cert.uuid, request.params)
repo_response = ForemanApi.new.fetch_host_repositories(client_cert.uuid, request.params)
halt repo_response.code.to_i, repo_response.body unless repo_response.code.to_i == 200

Copy link
Member Author

@sjha4 sjha4 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.. 👍🏼

halt repo_response.code.to_i, repo_response.body unless repo_response.code.to_i == 200
container_gateway_main.update_host_repositories(client_cert.uuid,
JSON.parse(repo_response.body)['repositories'])
end
catalog = container_gateway_main.host_catalog(client_cert.uuid).select_map(::Sequel[:repositories][:name])
pulp_index = JSON.parse(pulp_response.body)
halt 400, "Error: 'Results' key is missing in pulp_index" unless pulp_index.key?("Results")
pulp_index["Results"].select! { |result| catalog.include?(result["Name"]) }
Copy link
Member

@ianballou ianballou Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could check if there is a Results section and throw an error otherwise.

Copy link
Member Author

@sjha4 sjha4 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.. 👍🏼

status 200
body pulp_index.to_json
else
status pulp_response.code.to_i
body pulp_response.body
end
end

get '/v1/_ping/?' do
Expand Down Expand Up @@ -369,7 +377,14 @@ def handle_unauthorized_access(username)

def handle_client_cert_auth(repository)
client_cert = ::Cert::RhsmClient.new(cert_from_request) if valid_cert?
if client_cert&.uuid&.present?
valid_uuid = client_cert&.uuid&.present?
if valid_uuid
host = database.connection[:hosts][{ uuid: client_cert.uuid }]
if host.nil?
repo_response = ForemanApi.new.fetch_host_repositories(client_cert.uuid, request.params)
container_gateway_main.update_host_repositories(client_cert.uuid,
JSON.parse(repo_response.body)['repositories'])
end
halt 401, "unauthorized" unless container_gateway_main.cert_authorized_for_repo?(repository, client_cert.uuid)
return true
end
Expand Down Expand Up @@ -454,5 +469,6 @@ def v1_foreman_authorized_username
end
end
end
# rubocop:enable Metrics/ClassLength
end
end