Smart proxy sync can fail when host has no bound container repos #57
+118
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
empty_repo_host_mapping
branch
from
b99f00b to
31b0a5c
Compare
sjha4
force-pushed
the
empty_repo_host_mapping
branch
from
31b0a5c to
b14382d
Compare
qcjames53
approved these changes
Sep 12, 2025
Contributor
qcjames53
left a comment
qcjames53
left a comment
There was a problem hiding this comment.
I can confirm build_host_entries returns a correct selection of repositories over a variety of scenarios. The host_repositories table appears to be left empty/filled where appropriate. The current unit tests seem good to me. There is a little overlap with some of the tests (nil vs empty lists) but I'll never knock a PR for too many unit tests :)
ACKing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
The sync should finish successfully.
Check the hosts_repositories table, it should be empty.
Try the happy path with a host registered to proxy with some container repos in an authenticated pull environment. Make sure the hosts_repositories table gets properly populated.
Tests in the PR are AI generated with claude code. Looks comprehensive so pushing it as part of PR.