Skip to content

FEAT: Multiple backup slots, Emulator C-lib replaced with C++ class (Pybind), gymnasium support, ditched Scons, Refactor & Clean-ups #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

FEAT: Multiple backup slots, Emulator C-lib replaced with C++ class (Pybind), gymnasium support, ditched Scons, Refactor & Clean-ups #90

wants to merge 27 commits into from

Conversation

@ali-mosavian
Copy link

@ali-mosavian ali-mosavian commented Dec 16, 2022 •
edited
Loading

Description

  • Adds the ability to backup/restore to/from 10+1 slots, where the default slot is -1 (used for reset)
  • Upgraded pyglet to latest version, the required version does not work on MacOS Ventura.

Type of change

Please select all relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Only manual testing.

Test Configuration

  • Operating System: MacOS Ventura
  • Python version: 3.10.8
  • C++ compiler version: Apple clang version 14.0.0 (clang-1400.0.29.202)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

ali-mosavian and others added 11 commits December 16, 2022 11:28
@ali-mosavian
FEAT: Added ability to backup to 10+1 (-1 is main slot for reset) slo…
c4d6b1a 
…ts. Upgraded pyglet to work with macos ventura
@ali-mosavian
CHG: Changed to std::array
6658e21
@ali-mosavian
CHG: Renamed state to core which emulator inherits from, makes copyin…
a640ce6 
…g/resting state sligthly easier.
@ali-mosavian
CHG: Added explicit snapshot/restore to py env and fixed newer gym co…
fc90f45 
…mpability in step.
@ali-mosavian
FIX: Syntax errors.
cb9c7ab
@ali-mosavian
FIX: Call did reset after a restore.
76419ad
@ali-mosavian
CHG: Refactor, using pybind11 instead of ctypes.cdll
d0cd94a
@ali-mosavian
FEAT: Fixed tests and added build script for python 3.8-3.13, upgrade…
4960d91 
…d to gymnasium 1.0.0
@ali-mosavian
FIX: video.frames_per_second -> render_fps (gymnasium)
b43d857
@ali-mosavian
CHG: Using super reset instead
1166a70
@ali-mosavian
CHG: Ditched SCons and pivoted to Make for building emulator. Lots of…
d3f5315 
… issues with scons and venvs
@ali-mosavian ali-mosavian changed the title FEAT: Ability to backup/restore to/from 10+1 slots FEAT: Multiple backup slots, gymnasium support, ditched Scons, Refactor Dec 29, 2024
@ali-mosavian ali-mosavian changed the title FEAT: Multiple backup slots, gymnasium support, ditched Scons, Refactor FEAT: Multiple backup slots, Emulator C-lib replaced with C++ class (Pybind), gymnasium support, ditched Scons, Refactor Dec 29, 2024
@ali-mosavian ali-mosavian changed the title FEAT: Multiple backup slots, Emulator C-lib replaced with C++ class (Pybind), gymnasium support, ditched Scons, Refactor FEAT: Multiple backup slots, Emulator C-lib replaced with C++ class (Pybind), gymnasium support, ditched Scons, Refactor & Clean-ups Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ali-mosavian