Skip to content

Honor durable tool headroom on successor turns - #1151

Open
KeenWill wants to merge 1 commit into
agent/daemon-live-bounds-activation-stackfrom
agent/daemon-live-headroom-proof-activation
Open

Honor durable tool headroom on successor turns#1151
KeenWill wants to merge 1 commit into
agent/daemon-live-bounds-activation-stackfrom
agent/daemon-live-headroom-proof-activation

Conversation

@KeenWill

Copy link
Copy Markdown
Owner

What changed

The queued-turn context guard now retains a durable same-turn headroom-exhaustion record's projected tool-result bytes as the conservative minimum when recomputing unreported content. A successor frontier that omits those result entries can no longer erase the typed proof that compaction is required. The existing latest-compaction frontier rule still supersedes old proof after a successful compaction.

The INV-014 PostgreSQL scenario now checks both the tool-result frontier and the successor frontier that previously reduced the allowance to zero. The model-call execution contract records the durable-proof behavior.

Meaningfully changed lines: 69. Numeric-bound ceilings added: none.

Validation

  • focused INV-014 PostgreSQL integration regression: green
  • workspace format, check, clippy, doctests, rustdoc, metadata: green
  • workspace unit suite: change-relevant targets green; unrelated environment-sensitive tests remain non-green locally
  • documentation checks: green except the inherited pre-merge PR Make numeric-bound declarations fail closed #1125 carrier-history check
  • web-search live smoke: intentionally ignored because it requires a live provider credential

Copilot AI lite review requested due to automatic review settings August 23, 2026 00:36
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Your free Security trial is over. An organization admin can activate billing to continue.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Approval pending

CodeRabbit has no unresolved comments, but it skipped the latest review.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 779cfb0810

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/persistence/src/model_execution.rs
@github-actions

Copy link
Copy Markdown
Contributor

Rust coverage (report only)

Report only. This measurement has no threshold, gates no merge, and
fails no check; it exists so untested code stays visible.

Measured suite Outcome
workspace (--all-targets --all-features) failure
persistence PostgreSQL (--ignored) success
signalboxd PostgreSQL (--ignored) failure
terminal-client PostgreSQL (--ignored) success
What this number does not measure
  • Doctests. cargo llvm-cov --doctests needs a nightly
    toolchain; this workspace pins stable, so the compile-fail
    sealing proofs and every other doctest are outside the
    denominator.
  • Live smokes, which spend real network requests or
    credentials and are never run here: the tools-github and
    tools-web smokes stay --ignored, and the whole-daemon and
    real-provider terminal smokes are skipped by name above.
  • The Swift native client, which Xcode measures separately.
  • One environment-clearing test in signalbox-tools-exec,
    which instrumenting its supervisor process perturbs. The
    workflow comment on the workspace step states why; rust.yml
    runs that test uninstrumented and gates on it.
  • Dedicated test files. cargo-llvm-cov excludes tests/
    and benches/ targets and *tests.rs modules from the
    report by default, so that test code is counted neither
    covered nor uncovered here. Inline #[cfg(test)] modules
    inside a source file are the exception: they are
    instrumented, and they land on both sides. A test body
    that ran counts as covered, which makes every percentage
    below optimistic; the body of an #[ignore]d test no
    measured suite runs counts as uncovered, which puts test
    lines into the file ranking. Read both tables as close,
    not exact.
Measure Covered Total Percent
Lines 253824 310998 81.62%
Functions 20701 25155 82.29%
Regions 321583 402358 79.92%

Per crate, least-covered first

Crate Line % Lines Function % Region %
crates/program-runtime 7.57% 38/502 5.77% 6.13%
crates/runner-wire 60.41% 644/1066 62.67% 59.14%
apps/signalboxd 63.69% 35460/55674 70.79% 63.59%
crates/tools-sessions 65.06% 378/581 63.29% 61.68%
apps/signalbox-runner 69.47% 1784/2568 70.93% 70.29%
crates/approval-judge-eval 73.87% 492/666 76.12% 76.41%
crates/tool-schema-derive 74.20% 279/376 88.00% 72.42%
crates/tools-basic 75.37% 771/1023 66.15% 79.16%
crates/model-runtime-claude-cli 76.49% 1653/2161 73.10% 77.35%
crates/tools-github 77.06% 2408/3125 74.19% 74.82%
crates/tools-exec 77.67% 5190/6682 75.04% 73.95%
apps/client 78.88% 13283/16840 89.58% 75.76%
crates/persistence 80.06% 53909/67332 78.03% 75.48%
crates/tools-code-host 80.39% 7089/8818 80.46% 76.60%
crates/blob-store-filesystem 80.50% 1371/1703 70.17% 80.45%
crates/model-provider-runtime 81.47% 2454/3012 85.71% 79.95%
crates/blob-store 82.57% 308/373 75.41% 83.68%
crates/tools-conversations 83.01% 508/612 83.78% 77.65%
crates/egress-transport 85.35% 134/157 83.33% 77.61%
crates/conversation-import-claude-code 85.45% 740/866 66.09% 84.67%
crates/tools-plan 85.71% 768/896 88.89% 81.74%
crates/conversation-import-codex 85.76% 873/1018 64.00% 83.56%
crates/tools-workspace 86.36% 2977/3447 82.14% 87.30%
crates/tools-web 86.59% 2978/3439 87.93% 85.03%
crates/tools-git 87.40% 8750/10011 86.50% 83.24%
crates/application 88.63% 19154/21610 87.86% 88.80%
crates/model-runtime-codex-cli 90.00% 1548/1720 90.98% 89.95%
crates/test-bin 90.91% 10/11 100.00% 70.00%
crates/domain 92.28% 60106/65137 91.36% 94.12%
crates/web-contract 92.31% 408/442 82.61% 82.09%
crates/conversation-import-json 92.51% 284/307 96.88% 91.36%
crates/model-runtime-openai 93.55% 3812/4075 97.50% 91.72%
crates/process-protocol 93.67% 8469/9041 95.89% 86.68%
crates/model-runtime-anthropic 93.88% 3910/4165 97.51% 91.26%
crates/model-runtime 93.96% 9219/9812 93.29% 94.69%
crates/expect-table 95.60% 977/1022 100.00% 95.75%
crates/tool-contract 97.18% 688/708 96.47% 95.54%

25 files with the most uncovered lines

File Uncovered lines Line %
apps/signalboxd/src/process_runtime.rs 6570 53.44%
apps/signalboxd/src/repo_watch_runtime.rs 2235 69.20%
apps/signalboxd/src/runner_protocol_runtime.rs 2212 34.75%
crates/persistence/src/submit_input.rs 2071 71.81%
apps/client/src/lib.rs 1697 79.51%
apps/signalboxd/src/review_orchestration_runtime.rs 1333 2.56%
apps/signalboxd/src/main.rs 1305 47.38%
crates/persistence/src/model_execution.rs 1243 84.57%
crates/domain/src/turn_eligibility.rs 1223 90.33%
crates/persistence/src/runner_protocol.rs 1157 82.16%
crates/tools-code-host/src/code_host/github.rs 1052 76.26%
crates/persistence/src/review_workflow.rs 997 77.35%
crates/tools-exec/src/bin/signalbox-exec-supervisor.rs 885 45.61%
crates/persistence/src/tool_loop.rs 732 76.49%
crates/tools-github/src/lib.rs 717 76.47%
apps/signalboxd/src/convergence_sweep_runtime.rs 683 22.21%
apps/client/src/presentation.rs 680 80.55%
crates/persistence/src/process_read.rs 679 82.35%
apps/signalboxd/src/lib.rs 647 72.20%
crates/domain/src/submit_input.rs 640 88.03%
apps/signalboxd/src/daemon_tools.rs 573 89.68%
crates/process-protocol/src/lib.rs 572 93.67%
crates/persistence/src/review_orchestration.rs 569 75.66%
crates/persistence/src/session_delegation.rs 543 77.63%
crates/application/src/model_execution.rs 541 86.05%

Measured at 5b86c8a39ded66fd81cb26e638b10a0dae4d6614, the merge commit this pull request builds, whose head is 779cfb08104bb337ee1dd40e71f41ee86905764d, by run 32608309148, which uploads the HTML report and LCOV as an artifact.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.27%. Comparing base (1fd78d4) to head (779cfb0).

Additional details and impacted files
Flag Coverage Δ
rust 82.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants