Skip to content

Close reported-usage compaction gaps - #1163

Open
KeenWill wants to merge 1 commit into
agent/daemon-live-compaction-review-fixesfrom
agent/daemon-live-compaction-production-closure
Open

Close reported-usage compaction gaps#1163
KeenWill wants to merge 1 commit into
agent/daemon-live-compaction-review-fixesfrom
agent/daemon-live-compaction-production-closure

Conversation

@KeenWill

Copy link
Copy Markdown
Owner

Summary

  • re-read provider-reported context headroom after a successful automatic compaction
  • close a still-oversized queued turn call-free before ordinary provider dispatch
  • raise fatal startup-recovery supervision when that closure commit is ambiguous
  • keep the compaction-failure tests straight-line and add a PostgreSQL regression for an insufficient successful summary

Meaningfully changed lines (excluding lockfiles): 400.

Validation

  • cargo fmt --all -- --check
  • cargo check -p signalboxd --all-targets --all-features
  • cargo clippy -p signalboxd --all-targets --all-features -- -D warnings
  • focused ambiguity unit regression: green
  • failed-compaction PostgreSQL regression: green
  • successful-but-still-oversized PostgreSQL regression: green
  • affected signalboxd suite: new tests green; inherited host-sensitive socket/web and repo-watch timing fixtures failed as on the deployed parent

Numeric-bound ceilings introduced by this PR: none.

Stack reconstruction ledger

This PR is stacked on #1162 and was deployed through deploy/dogfood-live before review.

Copilot AI lite review requested due to automatic review settings August 23, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d5cb728-2462-4e9b-ad00-39b148cba9d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate billing to continue.


Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@github-actions

Copy link
Copy Markdown
Contributor

Rust coverage (report only)

Report only. This measurement has no threshold, gates no merge, and
fails no check; it exists so untested code stays visible.

Measured suite Outcome
workspace (--all-targets --all-features) success
persistence PostgreSQL (--ignored) success
signalboxd PostgreSQL (--ignored) failure
terminal-client PostgreSQL (--ignored) success
What this number does not measure
  • Doctests. cargo llvm-cov --doctests needs a nightly
    toolchain; this workspace pins stable, so the compile-fail
    sealing proofs and every other doctest are outside the
    denominator.
  • Live smokes, which spend real network requests or
    credentials and are never run here: the tools-github and
    tools-web smokes stay --ignored, and the whole-daemon and
    real-provider terminal smokes are skipped by name above.
  • The Swift native client, which Xcode measures separately.
  • One environment-clearing test in signalbox-tools-exec,
    which instrumenting its supervisor process perturbs. The
    workflow comment on the workspace step states why; rust.yml
    runs that test uninstrumented and gates on it.
  • Dedicated test files. cargo-llvm-cov excludes tests/
    and benches/ targets and *tests.rs modules from the
    report by default, so that test code is counted neither
    covered nor uncovered here. Inline #[cfg(test)] modules
    inside a source file are the exception: they are
    instrumented, and they land on both sides. A test body
    that ran counts as covered, which makes every percentage
    below optimistic; the body of an #[ignore]d test no
    measured suite runs counts as uncovered, which puts test
    lines into the file ranking. Read both tables as close,
    not exact.
Measure Covered Total Percent
Lines 254128 311579 81.56%
Functions 20722 25190 82.26%
Regions 321914 403035 79.87%

Per crate, least-covered first

Crate Line % Lines Function % Region %
crates/program-runtime 7.57% 38/502 5.77% 6.13%
crates/runner-wire 60.41% 644/1066 62.67% 59.14%
apps/signalboxd 63.55% 35528/55909 70.73% 63.45%
crates/tools-sessions 65.06% 378/581 63.29% 61.68%
apps/signalbox-runner 69.47% 1784/2568 70.93% 70.29%
crates/approval-judge-eval 73.87% 492/666 76.12% 76.41%
crates/tool-schema-derive 74.20% 279/376 88.00% 72.42%
crates/tools-basic 75.37% 771/1023 66.15% 79.16%
crates/model-runtime-claude-cli 76.51% 1655/2163 73.10% 77.37%
crates/tools-github 77.06% 2408/3125 74.19% 74.82%
crates/tools-exec 77.79% 5198/6682 75.04% 74.10%
apps/client 78.88% 13283/16840 89.58% 75.76%
crates/persistence 79.96% 53986/67519 77.94% 75.37%
crates/tools-code-host 80.39% 7089/8818 80.46% 76.60%
crates/blob-store-filesystem 80.50% 1371/1703 70.17% 80.45%
crates/model-provider-runtime 81.37% 2463/3027 85.71% 79.97%
crates/blob-store 82.57% 308/373 75.41% 83.68%
crates/tools-conversations 83.01% 508/612 83.78% 77.65%
crates/egress-transport 85.35% 134/157 83.33% 77.61%
crates/conversation-import-claude-code 85.45% 740/866 66.09% 84.67%
crates/tools-plan 85.71% 768/896 88.89% 81.74%
crates/conversation-import-codex 85.76% 873/1018 64.00% 83.56%
crates/tools-workspace 86.36% 2977/3447 82.14% 87.30%
crates/tools-web 86.59% 2978/3439 87.93% 85.03%
crates/tools-git 87.40% 8750/10011 86.50% 83.24%
crates/application 88.65% 19184/21640 87.86% 88.81%
crates/model-runtime-codex-cli 90.01% 1550/1722 90.98% 89.96%
crates/test-bin 90.91% 10/11 100.00% 70.00%
crates/domain 92.29% 60212/65245 91.37% 94.13%
crates/web-contract 92.31% 408/442 82.61% 82.09%
crates/conversation-import-json 92.51% 284/307 96.88% 91.36%
crates/model-runtime-openai 93.55% 3812/4075 97.50% 91.72%
crates/process-protocol 93.67% 8469/9041 95.89% 86.68%
crates/model-runtime-anthropic 93.88% 3910/4165 97.51% 91.26%
crates/model-runtime 93.96% 9221/9814 93.29% 94.69%
crates/expect-table 95.60% 977/1022 100.00% 95.75%
crates/tool-contract 97.18% 688/708 96.47% 95.54%

25 files with the most uncovered lines

File Uncovered lines Line %
apps/signalboxd/src/process_runtime.rs 6580 53.40%
apps/signalboxd/src/repo_watch_runtime.rs 2235 69.20%
apps/signalboxd/src/runner_protocol_runtime.rs 2212 34.75%
crates/persistence/src/submit_input.rs 2071 71.81%
apps/client/src/lib.rs 1697 79.51%
apps/signalboxd/src/review_orchestration_runtime.rs 1333 2.56%
apps/signalboxd/src/main.rs 1305 47.38%
crates/persistence/src/model_execution.rs 1269 84.34%
crates/domain/src/turn_eligibility.rs 1223 90.33%
crates/persistence/src/runner_protocol.rs 1157 82.16%
crates/tools-code-host/src/code_host/github.rs 1052 76.26%
crates/persistence/src/review_workflow.rs 997 77.35%
crates/tools-exec/src/bin/signalbox-exec-supervisor.rs 885 45.61%
crates/persistence/src/tool_loop.rs 749 76.07%
crates/tools-github/src/lib.rs 717 76.47%
apps/signalboxd/src/convergence_sweep_runtime.rs 683 22.21%
crates/persistence/src/process_read.rs 681 82.33%
apps/client/src/presentation.rs 680 80.55%
apps/signalboxd/src/lib.rs 649 72.50%
crates/domain/src/submit_input.rs 640 88.03%
apps/signalboxd/src/daemon_tools.rs 573 89.68%
crates/process-protocol/src/lib.rs 572 93.67%
crates/persistence/src/review_orchestration.rs 569 75.66%
crates/persistence/src/session_delegation.rs 543 77.63%
crates/application/src/model_execution.rs 541 86.15%

Measured at 62595e2ab7c268a48136bb561508707b7e15e7e4, the merge commit this pull request builds, whose head is 609c230e82711a386b9955d79a72d2fee40afbf0, by run 32628002814, which uploads the HTML report and LCOV as an artifact.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.58621% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (115c6f9) to head (609c230).

Files with missing lines Patch % Lines
apps/signalboxd/src/context_guard.rs 0.00% 78 Missing ⚠️
apps/signalboxd/src/lib.rs 84.21% 6 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
rust 82.80% <27.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants