Skip to content

Classify Codex native context-limit messages #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KeenWill wants to merge 1 commit into
base: agent/daemon-live-request-too-large-compaction
Choose a base branch
from
Open

Classify Codex native context-limit messages #1170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/model-runtime-codex-cli/src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ pub(crate) fn classify_error(message: &str) -> ProviderErrorKind {
"context length exceeded",
"context window exceeded",
"context_length_exceeded",
"ran out of room in the model's context window",
"input exceeds the maximum length",
],
) =>
{
Expand Down Expand Up @@ -210,6 +212,20 @@ mod tests {
);
}

#[test]
fn codex_native_context_limit_messages_are_request_too_large() {
assert_eq!(
classify_error(
"Codex ran out of room in the model's context window. Start a new thread or clear earlier history before retrying."
),
ProviderErrorKind::RequestTooLarge
);
assert_eq!(
classify_error("Input exceeds the maximum length of this model"),
ProviderErrorKind::RequestTooLarge
);
}

#[test]
fn credential_rejection_precedes_refusal_shaped_text() {
assert_eq!(
Expand Down
Loading