Park impossible context compaction - #1176
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate billing to continue. Comment |
|
@codex review Please review exact head |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Rust coverage (report only)Report only. This measurement has no threshold, gates no merge, and
What this number does not measure
Per crate, least-covered first
25 files with the most uncovered lines
Measured at |
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d62e088a6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let resumption = match adapter | ||
| .repository | ||
| .execution_failure_recovery_cause(session, turn) | ||
| .await? |
There was a problem hiding this comment.
This cause-aware selection runs only in the direct failure callback. If the daemon restarts after the failed-turn transaction commits but before that callback disposes the goal, reconcile_success still selects Scheduled; likewise, an ambiguous block commit is reread by reconcile_ambiguous_block, which also unconditionally plans automatic resumption. Both paths therefore arm a resume for a turn carrying context_compaction_input_does_not_fit, defeating the durable parking behavior and potentially repeating the impossible turn until the attempt budget is exhausted. Reuse the cause-aware selection in both reconciliation paths, deriving the failed turn from the current terminal turn or block provenance.
Useful? React with 👍 / 👎.
Summary
context_compaction_input_does_not_fitrecovery record in the same transaction that closes the call-free failed turnMeaningfully changed lines: 456 (no lockfile changes).
Validation
202608210617/tmpis owned bynobody(13 local-socket permission tests) and the host lacks theUS/Easternzoneinfo alias (one current-time test)mainNumeric-bound ledger: this slice adds or changes no numeric bound.