Open
Conversation
to fix distribution of py.typed and *.pyi
git_archive_all{ → /__init__}.py
nim65s
added a commit
to cmake-wheel/cmeel
that referenced
this pull request
Aug 4, 2023
Author
|
While here, I'm also adding a type hint for the main function, to fix the following mypy error: |
Author
|
Hi @Kentzo, This is a little ping : could you have a look at this simple PR ? Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The current distribution archives are not including
py.typedand*.pyi, because thegit_archive_allmodule don't contain them.As a result, on a project which has git_archive_all as dependency, mypy shows:
error: Skipping analyzing "git_archive_all": module is installed, but missing library stubs or py.typed marker [import]A fix for this is to re-organize the module from
name.pytoname/__init__.pyto be able to include other files inname/.To validate this, here are the logs of
python -m wheel -v .