-
Notifications
You must be signed in to change notification settings - Fork 7
Change font references to relative paths #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @basic:~ ""; | ||
| .font-srcs() when not (@basic) { | ||
| src: url(/fonts/Symbola.eot); | ||
| src: url(../fonts/Symbola.eot); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are now the actual, relative paths to the font files. lessc can now resolve them properly when building.
jeresig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you!
nedredmond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jeremywiebe !
|
Questions though:
|
John asked the same question and I couldn't answer because I didn't take care to write things down as I was working. I remember hitting a wall in webapp when I went to integrate it though.
Good catch! I'll bump this PR to v1.0.3! |
|
@nedredmond Oh, I remember now. When I did this originally I didn't update Perseus to properly bundle the fonts... and so I was fighting with the bundlers in webapp trying to find the fonts manually during bundling. This round, I've adjusted Perseus to properly bundle both mathquill CSS and fonts, so that the font references in the processed CSS are correct. |
Summary:
This PR adjusts the Symbola font references in Mathquill Less files to be relative paths. It also updates the build pipeline so that the generated CSS contains correct relative paths to these font files relative to the build output folder.
I also noticed that there was a reference to an
.otffont file that no longer exists in the repo. It seems like this is just "code rot" as the code changed.Issue: LEMS-3019
Test plan:
I ran the build and inspected the CSS and made sure that the relative font paths for Symbola resolved to the actual files in the build folder.