Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NumericInput and InputNumber scoring logic to perseus-score #2105

Open
wants to merge 1 commit into
base: LEMS-2737/categorizer
Choose a base branch
from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jan 14, 2025

Summary:

I ended up moving them at the same time because of their shared dependency on TexWrangler.

  • Move InputNumber and NumericInput scoring logic to perseus-score
  • Move TexWranger since it was only used by their scoring logic
  • Update imports
  • Consolidate and rename InputNumber's answerTypes

Issue: LEMS-2737

Test plan:

Nothing should change, just moving code

@handeyeco handeyeco self-assigned this Jan 14, 2025
@handeyeco handeyeco changed the title move numeric-input and input-number Move NumericInput and InputNumber scoring logic to perseus-score Jan 14, 2025
@handeyeco handeyeco requested review from a team January 14, 2025 20:41
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (55db9f3) and published it to npm. You
can install it using the tag PR2105.

Example:

yarn add @khanacademy/perseus@PR2105

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2105

Copy link
Contributor

Size Change: -140 B (-0.01%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 689 kB -116 B (-0.02%)
packages/perseus-score/dist/es/index.js 106 kB +3.21 kB (+3.11%)
packages/perseus/dist/es/index.js 408 kB -3.23 kB (-0.79%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 83.1 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 23.1 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 4.83 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant