Fix memory leak. (#991)

Fixes #990.
KhronosGroup · Mar 6, 2025 · e0cf193 · e0cf193
1 parent 8edc880
commit e0cf193
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/basis_transcode.cpp b/lib/basis_transcode.cpp
@@ -494,6 +494,11 @@ ktxTexture2_transcodeLzEtc1s(ktxTexture2* This,
     uint32_t& imageCount = firstImages[This->numLevels];
 
     if (BGD_TABLES_ADDR(0, bgdh, imageCount) + bgdh.tablesByteLength > priv._sgdByteLength) {
+        // Compiler will not allow `goto cleanup;` because "jump bypasses variable initialization."
+        // The static initializations below this and before the loop are presumably the issue
+        // as the compiler is,presumably, inserting code to destruct those at the end of the
+        // function.
+        delete[] firstImages;
         return KTX_FILE_DATA_ERROR;
     }
     // FIXME: Do more validation.