Allow canceling / reverting prompt enhancement #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81148d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hassoncs
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for canceling and reverting prompt enhancements in the chat UI.
- Introduces
cancelEnhancementandrevertEnhancementlabels in all locales. - Updates
ChatTextAreato store original/enhanced prompt state and handle cancel/revert flows. - Adds unit and E2E tests covering enhancement, cancellation, and revert behaviors.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webview-ui/src/i18n/locales/*/kilocode.json | Added enhancePrompt translations for all locales |
| webview-ui/src/components/chat/ChatTextArea.tsx | Implemented prompt cancellation and revert logic |
| webview-ui/src/components/chat/tests/ChatTextArea.spec.tsx | Added tests for cancel/revert prompt enhancement |
| apps/playwright-e2e/tests/enhance-prompt.test.ts | New E2E tests for prompt enhancement flows |
| apps/playwright-e2e/tests/chat-with-response-refactored.test.ts | New refactored chat E2E test |
| apps/playwright-e2e/playwright.config.ts | Adjusted retry settings |
| apps/playwright-e2e/helpers/test-setup-helpers.ts | Extracted shared test setup helper |
| apps/playwright-e2e/helpers/enhance-prompt-helpers.ts | Helper functions for E2E prompt enhancement tests |
| apps/playwright-e2e/helpers/chat-helpers.ts | Helper functions for E2E chat interactions |
Comments suppressed due to low confidence (1)
webview-ui/src/components/chat/ChatTextArea.tsx:1480
- The translation key namespace appears incorrect; verify whether it should be
t("chat:enhancePrompt.cancelEnhancement")instead oft("kilocode:chat.enhancePrompt.cancelEnhancement").
title={
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
2 times, most recently
from
14246b7 to
354d9d2
Compare
|
related? RooCodeInc/Roo-Code#5742 |
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
from
3f8688a to
d7a8933
Compare
|
@chrarnoldus, oh yeah! Looks like they built a rough version of this based on the native undo! I'll see what parts of this make sense to keep around |
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
2 times, most recently
from
473383d to
0a08647
Compare
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
from
0a08647 to
4d7d434
Compare
Extract common setup logic into a dedicated helper function `setupTestEnvironment`. Introduce new helper files for chat interactions and consolidate exports. This improves test readability and reduces duplication in E2E tests.
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
from
4d7d434 to
91a0a89
Compare
Adds the ability to revert an enhanced prompt back to its original state. This includes: - New state management in `ChatTextArea` to track original and enhanced prompts. - Logic to switch the enhance button between "enhance", "cancel", and "revert" states. - New Playwright E2E tests to cover the full enhancement workflow, including cancellation and reverting. - Updates to i18n files for new button labels.
hassoncs
force-pushed
the
cancel-revert-enhancement
branch
from
91a0a89 to
81148d5
Compare
hassoncs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow canceling / reverting prompt enhancement!