Fix: Workaround for detected changes in SettingsView upon rendering#455
Merged
kevinvandijk merged 2 commits intomainfrom May 21, 2025
Merged
Fix: Workaround for detected changes in SettingsView upon rendering#455kevinvandijk merged 2 commits intomainfrom
kevinvandijk merged 2 commits intomainfrom
Conversation
I've been going down a rabbit hole, trying to figure out why some users were seeing unsaved changes upon rendering the SettingsView for the first time. We've been dealing with this issue multiple times in the past, most recently in #354. I'm of the opinion that at some point we should rework the SettingsView and especially how state is being managed inside of it. There's simply too many opportunity to run into these situations because individual components are in charge of defaults and fallbacks, which will always keep triggering unsaved changes upon first render. With this workaround I simply make sure that we get users out of the state that poisoned their settings state.
|
kevinvandijk
approved these changes
May 21, 2025
|
|
||
| if (renderTime < 100 && isChangeDetected) { | ||
| console.info("Overwriting unsaved changes in less than 100ms") | ||
| onConfirmDialogResult(true) |
Contributor
There was a problem hiding this comment.
🤢
Yes, I see what you mean... Truly proud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been going down a rabbit hole, trying to figure out why some users were seeing unsaved changes upon rendering the SettingsView for the first time.
We've been dealing with this issue multiple times in the past, most recently in #354.
I'm of the opinion that at some point we should rework the SettingsView and especially how state is being managed inside of it. There's simply too many opportunity to run into these situations because individual components are in charge of defaults and fallbacks, which will always keep triggering unsaved changes upon first render. With this workaround I simply make sure that we get users out of the state that poisoned their settings state.