fix: disable zsh history expansion to prevent commands with ! from failing (#807) #4926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7aac84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ari4ka
approved these changes
Jan 11, 2026
Collaborator
|
Thank you! Looks good to me! I'll test it locally |
…iling Fixes Kilo-Org#807 Added `setopt NO_BANG_HIST` to the zsh initialization in ShellIntegrationManager. This prevents zsh from interpreting the `!` character as a history expansion character, which causes commands like `--collectCoverageFrom="!pattern"` to fail with "event not found" error. This is similar to how we already handle other zsh-specific issues like PROMPT_EOL_MARK for special characters in output. Co-Authored-By: Claude <[email protected]>
YuriNachos
force-pushed
the
fix/zsh-history-expansion-807
branch
from
c58f3e8 to
079dffd
Compare
kevinvandijk
approved these changes
Feb 11, 2026
This was referenced Feb 11, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #807
Added
setopt NO_BANG_HISTto the zsh initialization inShellIntegrationManager.This prevents zsh from interpreting the
!character as a history expansion character.Problem
When commands contain
!(like in--collectCoverageFrom="!services/refactor-code/**/*.test.ts"),zsh interprets it as history expansion and the command fails with "event not found" error,
causing Kilo Code to get stuck in a "waiting" state.
Solution
The fix adds
setopt NO_BANG_HISTto the temporary.zshrcfile created byShellIntegrationManager. This disables history expansion for non-interactive shells,
which is the desired behavior for programmatic command execution.
This is similar to how we already handle other zsh-specific issues like
PROMPT_EOL_MARKfor special characters in output.
Testing
All existing tests pass (7386 passed, 87 skipped).
🤖 Generated with Claude Code