fix(gemini): prevent sending thinkingLevel to budget-only models #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a4b44f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Models like gemini-2.5-flash only support thinkingBudget, not thinkingLevel. When shouldUseReasoningBudget() returns false (due to settings), the code was incorrectly falling through to effort-based logic and sending thinkingLevel, causing a 400 INVALID_ARGUMENT error: "Thinking level is not supported for this model." Added a check for model.supportsReasoningEffort before attempting to use thinkingLevel, ensuring budget-only models don't receive unsupported params. Fixes Kilo-Org#4490
naga-k
force-pushed
the
fix/gemini-thinking-level
branch
from
19e0c09 to
608fc3e
Compare
chrarnoldus
reviewed
Jan 21, 2026
chrarnoldus
reviewed
Jan 21, 2026
chrarnoldus
reviewed
Jan 21, 2026
chrarnoldus
reviewed
Jan 21, 2026
This was referenced Feb 11, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gemini-2.5-flashonly supportthinkingBudget, notthinkingLevelshouldUseReasoningBudget()returned false, the code was incorrectly falling through to effort-based logic and sendingthinkingLevel, causing a 400 INVALID_ARGUMENT errormodel.supportsReasoningEffortbefore attempting to usethinkingLevelTest plan
gemini-2.5-flash- error no longer occursFixes #4490