Skip to content

Conversation

@markijbema
Copy link
Contributor

@markijbema markijbema commented Jan 26, 2026

Merges continuedev code into the ghost service directory

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 9ad8941

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markijbema markijbema marked this pull request as ready for review January 26, 2026 14:23
@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 26, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR performs a clean refactoring that moves the continuedev directory from src/services/continuedev/ to src/services/ghost/continuedev/. All changes are:

  • File renames with 100% content similarity (no logic changes)
  • Import path updates to reflect the new directory structure

The refactoring is consistent across all affected files and follows the project's pattern of organizing ghost-related services under src/services/ghost/.

Files Reviewed (9 files with changes)

Import path updates:

  • src/api/providers/__tests__/kilocode-openrouter.spec.ts - Updated import and mock paths
  • src/api/providers/__tests__/mistral-fim.spec.ts - Updated import and mock paths
  • src/api/providers/kilocode-openrouter.ts - Updated import path
  • src/api/providers/mistral.ts - Updated import path
  • src/services/ghost/types.ts - Updated relative imports
  • src/test-llm-autocompletion/llm-client.ts - Updated import path
  • src/test-llm-autocompletion/mock-context-provider.ts - Updated import paths

File renames (100+ files):

  • All files under src/services/continuedev/src/services/ghost/continuedev/

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 26, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
src/services/ghost/continuedev/core/util/treeSitter.ts 202 repoRoot resolves to src/ but fallbacks use repoRoot/src/... (likely src/src/...)
src/services/ghost/continuedev/core/util/treeSitter.ts 230 Same mismatch for WASM candidate paths
Other Observations (not in diff)

No issues noted outside diff hunks.

Files Reviewed (9 files)

@markijbema markijbema force-pushed the mark/merge-continuedev-into-ghost branch from 72f8af3 to f9c58b5 Compare February 11, 2026 08:59
@markijbema markijbema enabled auto-merge February 11, 2026 09:14
// The tree-sitter directory is at src/services/continuedev/tree-sitter/
const repoRoot = path.resolve(__dirname, "..", "..", "..", "..")
// The tree-sitter directory is at src/services/ghost/continuedev/tree-sitter/
const repoRoot = path.resolve(__dirname, "..", "..", "..", "..", "..")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: repoRoot resolution likely doesn’t match the fallback paths

repoRoot resolves 5 levels up from core/util, which lands at src/ (not the repository root). Some fallbacks below use path.join(repoRoot, "src", ...) / path.join(repoRoot, "src", "node_modules", ...), which then become src/src/... and are unlikely to ever exist.

Consider either (a) renaming this to srcRoot and dropping the extra "src" segment in the fallback paths, or (b) resolving to the actual repo root (one more ..) so the repoRoot + "src" fallbacks work as intended.


const filename = `tree-sitter-${supportedLanguages[fileExtension]}.wasm`
const repoRoot = path.resolve(__dirname, "..", "..", "..", "..")
const repoRoot = path.resolve(__dirname, "..", "..", "..", "..", "..")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Same repoRoot vs fallback-path mismatch here

This repoRoot is also used with fallbacks like path.join(repoRoot, "src", ...), which may not resolve correctly if repoRoot is src/ rather than the repository root. It’s worth aligning the variable meaning (repo root vs src root) with the constructed candidate paths to avoid hard-to-debug production resolution failures.

@markijbema markijbema merged commit bbf5bb6 into main Feb 11, 2026
12 checks passed
@markijbema markijbema deleted the mark/merge-continuedev-into-ghost branch February 11, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants