-
Notifications
You must be signed in to change notification settings - Fork 2k
Merge continuedev into ghost #5394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR performs a clean refactoring that moves the
The refactoring is consistent across all affected files and follows the project's pattern of organizing ghost-related services under Files Reviewed (9 files with changes)Import path updates:
File renames (100+ files):
|
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)No issues noted outside diff hunks. Files Reviewed (9 files)
|
72f8af3 to
f9c58b5
Compare
| // The tree-sitter directory is at src/services/continuedev/tree-sitter/ | ||
| const repoRoot = path.resolve(__dirname, "..", "..", "..", "..") | ||
| // The tree-sitter directory is at src/services/ghost/continuedev/tree-sitter/ | ||
| const repoRoot = path.resolve(__dirname, "..", "..", "..", "..", "..") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: repoRoot resolution likely doesn’t match the fallback paths
repoRoot resolves 5 levels up from core/util, which lands at src/ (not the repository root). Some fallbacks below use path.join(repoRoot, "src", ...) / path.join(repoRoot, "src", "node_modules", ...), which then become src/src/... and are unlikely to ever exist.
Consider either (a) renaming this to srcRoot and dropping the extra "src" segment in the fallback paths, or (b) resolving to the actual repo root (one more ..) so the repoRoot + "src" fallbacks work as intended.
|
|
||
| const filename = `tree-sitter-${supportedLanguages[fileExtension]}.wasm` | ||
| const repoRoot = path.resolve(__dirname, "..", "..", "..", "..") | ||
| const repoRoot = path.resolve(__dirname, "..", "..", "..", "..", "..") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Same repoRoot vs fallback-path mismatch here
This repoRoot is also used with fallbacks like path.join(repoRoot, "src", ...), which may not resolve correctly if repoRoot is src/ rather than the repository root. It’s worth aligning the variable meaning (repo root vs src root) with the constructed candidate paths to avoid hard-to-debug production resolution failures.
Merges continuedev code into the ghost service directory