fix: make file deletion auto-approve checkbox clickable (#4485) #5565
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 31, 2026 11:31
Change the default value of alwaysAllowDelete from false to true to be consistent with other auto-approve settings like alwaysAllowWrite and alwaysAllowReadOnly.
🦋 Changeset detectedLatest commit: b44e285 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Githubguy132010
changed the title
Conflicts in ExtensionStateContext.tsx and AutoApproveSettings.tsx have been resolved: - Set alwaysAllowDelete default to true for consistency with other auto-approve settings - Preserved kilocode_change markers for tracking Kilo-specific modifications
Contributor
Author
|
Thanks for the review. Anything else? |
kevinvandijk
approved these changes
Feb 13, 2026
Collaborator
kevinvandijk
left a comment
kevinvandijk
left a comment
There was a problem hiding this comment.
I added some small changes but lgtm for the rest!
This was referenced Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4485. The file deletion auto-approve checkbox in the AutoApproveDropdown was not clickable because the
setAlwaysAllowDeletehandler was not being called when users tried to toggle the checkbox. Additionally, the default value foralwaysAllowDeletehas been set totruefor consistency with other auto-approve settings.Implementation
The fix involved adding the missing
setAlwaysAllowDeletestate setter to the following components:AutoApproveDropdown.tsx: Added
setAlwaysAllowDeleteto the destructured context values and implemented the case handler in the toggle switch statement. Also added it to the useCallback dependency array.AutoApproveSettings.tsx: Added
alwaysAllowDeleteprop to the component interface and passed it to the AutoApproveToggle component.SettingsView.tsx: Added
alwaysAllowDeleteto the destructured state and passed it through to AutoApproveSettings.ExtensionStateContext.tsx: Set the default value of
alwaysAllowDeletetotruefor consistency withalwaysAllowReadOnlyandalwaysAllowWritedefaults.All changes are marked with
// kilocode_changecomments as per project guidelines.Screenshots
N/A
How to Test
Get in Touch
Discord: thomas07374