fix(cli): fix flaky tests#9560
Conversation
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-2026-03-05 · 1,615,673 tokens |
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (4 files)
Reviewed by gpt-5.4-2026-03-05 · 950,378 tokens |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.5-2026-04-23 · 2,597,003 tokens |
| }, | ||
| }), | ||
| ) | ||
| // kilocode_change start - avoid blocking successful local plugins on background dependency installs |
There was a problem hiding this comment.
WARNING: Plugin initialization can race dependency setup again
Removing the post-load wait() means a local plugin that imports successfully but needs workspace dependencies during server() initialization now runs before config.waitForDependencies() completes. PluginLoader.loadExternal() only retries failures through module import, not failures from applyPlugin(), so these plugins will still be skipped instead of waiting or retrying after dependency setup.
Stabilizes the provider plugin test by avoiding global instance disposal and letting local plugins load before waiting on dependency setup.
This keeps the PR focused on the provider plugin flake: the remaining diff only touches plugin initialization and the provider test cleanup path.
All shared opencode changes are annotated with kilocode_change markers.