Skip to content

fix(cli): run plugin config() hooks before reading provider config #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilo-code-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

fix(cli): run plugin config() hooks before reading provider config #9566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/provider-plugin-ordering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"kilo-code": patch
---

Run plugin `config()` hooks before reading provider config and fetching models.dev data, so plugins that mutate `enabled_providers`, `disabled_providers`, or `provider` are consistently honored by the provider list and the kilo provider injection logic.
13 changes: 9 additions & 4 deletions packages/opencode/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,8 +1087,17 @@ const layer: Layer.Layer<
Effect.gen(function* () {
using _ = log.time("state")
const bridge = yield* EffectBridge.make()

// kilocode_change start
// Initialize plugins before reading config or fetching models.dev data so plugin
// config() hooks can mutate the shared config (provider, enabled_providers,
// disabled_providers) before any downstream consumer reads it. ModelsDev.get()
// reads enabled_providers/disabled_providers to decide whether to inject the
// kilo provider, so plugins must run first for that decision to see their mutations.
const plugins = yield* plugin.list()
const cfg = yield* config.get()
const modelsDev = yield* Effect.promise(() => ModelsDev.get())
// kilocode_change end
const database = mapValues(modelsDev, fromModelsDevProvider)

const providers: Record<ProviderID, Info> = {} as Record<ProviderID, Info>
Expand Down Expand Up @@ -1125,10 +1134,6 @@ const layer: Layer.Layer<
providers[providerID] = mergeDeep(match, provider)
}

// load plugins first so config() hook runs before reading cfg.provider
const plugins = yield* plugin.list()

// now read config providers - includes any modifications from plugin config() hook
const configProviders = Object.entries(cfg.provider ?? {})
const disabled = new Set(cfg.disabled_providers ?? [])
const enabled = cfg.enabled_providers ? new Set(cfg.enabled_providers) : null
Expand Down
Loading