-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: invoke skills as slash commands #9577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kilo-code-bot
wants to merge
2
commits into
main
Choose a base branch
from
mark/skill-slash-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "kilo-code": minor | ||
| "@kilocode/cli": minor | ||
| --- | ||
|
|
||
| Invoke skills as slash commands in the CLI TUI and VS Code sidebar. Each skill is available as `/<name>` when the name is free and always as `/skill:<name>`, so you can run a skill directly without going through the skill picker dialog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
packages/opencode/test/kilocode/skill-slash-command.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { afterEach, describe, expect } from "bun:test" | ||
| import { Effect, Layer } from "effect" | ||
| import { Command } from "../../src/command" | ||
| import { Instance } from "../../src/project/instance" | ||
| import * as CrossSpawnSpawner from "../../src/effect/cross-spawn-spawner" | ||
| import { provideTmpdirInstance } from "../fixture/fixture" | ||
| import { testEffect } from "../lib/effect" | ||
|
|
||
| const it = testEffect(Layer.mergeAll(Command.defaultLayer, CrossSpawnSpawner.defaultLayer)) | ||
|
|
||
| afterEach(async () => { | ||
| await Instance.disposeAll() | ||
| }) | ||
|
|
||
| describe("skills as slash commands", () => { | ||
| it.live("registers the built-in kilo-config skill under both /kilo-config and /skill:kilo-config", () => | ||
| provideTmpdirInstance( | ||
| () => | ||
| Effect.gen(function* () { | ||
| const svc = yield* Command.Service | ||
| const commands = yield* svc.list() | ||
|
|
||
| const bare = commands.find((c) => c.name === "kilo-config") | ||
| const aliased = commands.find((c) => c.name === "skill:kilo-config") | ||
|
|
||
| expect(bare).toBeDefined() | ||
| expect(bare!.source).toBe("skill") | ||
| expect(aliased).toBeDefined() | ||
| expect(aliased!.source).toBe("skill") | ||
| expect(aliased!.description).toBe(bare!.description) | ||
|
|
||
| // Both should resolve to the same skill content. | ||
| const bareTemplate = yield* Effect.promise(async () => await bare!.template) | ||
| const aliasedTemplate = yield* Effect.promise(async () => await aliased!.template) | ||
| expect(bareTemplate).toBe(aliasedTemplate) | ||
| expect(bareTemplate.length).toBeGreaterThan(0) | ||
| }), | ||
| { git: true }, | ||
| ), | ||
| ) | ||
|
|
||
| it.live("keeps /skill:<name> reachable even when the bare name is shadowed by a user command", () => | ||
| provideTmpdirInstance( | ||
| (dir) => | ||
| Effect.gen(function* () { | ||
| // Write a user command that collides with the built-in kilo-config skill name. | ||
| yield* Effect.promise(() => | ||
| Bun.write( | ||
| `${dir}/.kilo/command/kilo-config.md`, | ||
| `--- | ||
| description: user override command | ||
| --- | ||
|
|
||
| user template body | ||
| `, | ||
| ), | ||
| ) | ||
|
|
||
| const svc = yield* Command.Service | ||
| const commands = yield* svc.list() | ||
|
|
||
| const bare = commands.find((c) => c.name === "kilo-config") | ||
| const aliased = commands.find((c) => c.name === "skill:kilo-config") | ||
|
|
||
| expect(bare).toBeDefined() | ||
| expect(bare!.source).toBe("command") | ||
| expect(aliased).toBeDefined() | ||
| expect(aliased!.source).toBe("skill") | ||
|
|
||
| const bareTemplate = yield* Effect.promise(async () => await bare!.template) | ||
| const aliasedTemplate = yield* Effect.promise(async () => await aliased!.template) | ||
| expect(bareTemplate).toContain("user template body") | ||
| expect(aliasedTemplate).not.toBe(bareTemplate) | ||
| }), | ||
| { git: true }, | ||
| ), | ||
| ) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Client-command collisions hide the skill alias
bareSkillsis built before client commands are filtered out, so if a skill name matches a client-side slash command likesettingsorhelp, the bare skill is removed bynames.has(c.name)and this branch also removes/skill:<name>. That makes the skill unreachable in VS Code despite the alias guarantee. Consider only hiding the alias when the bare skill will actually be returned.