Skip to content

fix(cli): use Kilo cache for npm packages - #9581

Closed
lambertjosh wants to merge 1 commit into
mainfrom
fix/kilo-npm-cache-path
Closed

lambertjosh wants to merge 1 commit into
mainfrom
fix/kilo-npm-cache-path

Conversation

@lambertjosh

Copy link
Copy Markdown
Contributor

Summary

  • Routes the npm helper default layer through Kilo's global paths so npm-installed plugins and runtime packages cache under Kilo instead of opencode.
  • Adds a regression test for resolving npm-managed binaries from Kilo's cache path.

Comment thread packages/opencode/src/npm/index.ts Outdated
Layer.provide(EffectFlock.layer),
Layer.provide(AppFileSystem.layer),
Layer.provide(Global.layer),
Layer.provide(kilo),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Kilo-specific change is outside the annotation block

This line is the actual default-layer switch from the shared opencode global paths to Kilo paths, but it is not covered by a kilocode_change marker. The opencode annotation check scans added lines in shared packages/opencode files, so this and the related unmarked changed lines will fail CI unless they are covered by an inline marker or surrounding block.

Comment thread packages/opencode/test/npm.test.ts Outdated
import { describe, expect, test } from "bun:test"
import { Npm } from "../src/npm"
import { tmpdir } from "./fixture/fixture"
import { Global } from "../src/global"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Kilo-specific test changes need annotation coverage

packages/opencode/test/npm.test.ts is a shared opencode test file, and the added import plus regression test are Kilo-specific. The opencode annotation check will flag these added lines unless they are covered with kilocode_change markers.

@kilo-code-bot

kilo-code-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/fuzzy-pigs-drop.md
  • packages/kilo-docs/pages/automate/extending/plugins.md
  • packages/opencode/test/npm.test.ts
  • packages/shared/src/global.ts

Reviewed by gpt-5.5-20260423 · 1,131,194 tokens

@lambertjosh
lambertjosh force-pushed the fix/kilo-npm-cache-path branch 3 times, most recently from 10a2df6 to 19c0943 Compare April 30, 2026 14:58
@lambertjosh
lambertjosh force-pushed the fix/kilo-npm-cache-path branch from 19c0943 to 1d0dd69 Compare April 30, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant