Skip to content

Include trailing slash on dirs for autocomplete #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kimahriman merged 1 commit into from
Dec 31, 2025
Merged

Include trailing slash on dirs for autocomplete #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions python/hdfs_native/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from collections import defaultdict
from concurrent.futures import ThreadPoolExecutor, as_completed
from datetime import datetime, timezone
from typing import Dict, List, Optional, Sequence, Tuple, Union
from typing import Dict, Iterator, List, Optional, Sequence, Tuple, Union
from urllib.parse import urlparse

from argcomplete import autocomplete
Expand Down Expand Up @@ -179,12 +179,16 @@ def _human_size(num: int):
return f"{adjusted:.1f}Y"


def _client_completer(prefix: str, **kwargs) -> list[str]:
def _client_completer(prefix: str, **kwargs) -> Iterator[str]:
client = _client_for_url(prefix)
path_prefix = _prefix_for_url(prefix)

glob_results = client.glob_status(f"{_path_for_url(prefix)}*")
return [f"{path_prefix}{status.path}" for status in glob_results]
for status in glob_results:
if status.isdir:
yield f"{path_prefix}{status.path}/"
else:
yield f"{path_prefix}{status.path}"


def cat(args: Namespace):
Expand Down Expand Up @@ -908,8 +912,7 @@ def touch(args: Namespace):

def main(in_args: Optional[Sequence[str]] = None):
parser = ArgumentParser(
description="""Command line utility for interacting with HDFS using hdfs-native.
Globs are not currently supported, all file paths are treated as exact paths."""
description="""Command line utility for interacting with HDFS using hdfs-native."""
)

subparsers = parser.add_subparsers(title="Subcommands", required=True)
Expand Down
Loading