Skip to content

add before register function for rdma user buffer option #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WLBF wants to merge 1 commit into
base: nvidia_rdma
Choose a base branch
from
Open

add before register function for rdma user buffer option #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/aws/s3/s3_client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,8 @@ struct aws_s3_meta_request_options {
struct aws_byte_cursor copy_source_uri;
};

typedef int(aws_s3_user_buffer_before_register_fn)(void *user_data);

/* EXPERIMENTAL - User-provided buffer options for GET/PUT operations */
struct aws_s3_user_buffer_options {
/* Unified transfer buffer: PUT reads from it; GET writes into it. */
Expand All @@ -1046,6 +1048,7 @@ struct aws_s3_user_buffer_options {
* is already pinned and suitable for RDMA transfers. */
bool buffer_is_rdma_registered;
void *_reserved[4];
aws_s3_user_buffer_before_register_fn *before_register_callback;
};

/* Result details of a meta request.
Expand Down
16 changes: 16 additions & 0 deletions source/s3_rdma_buffer_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,22 @@ static int s_default_prepare_buffer_for_rdma(
AWS_LOGF_DEBUG(AWS_LS_S3_RDMA, "id=%p Buffer not suitable for RDMA", (void *)manager);
return AWS_OP_SUCCESS;
}

/* Run before register callback */
struct aws_s3_meta_request *meta_request = request->meta_request;
if (meta_request->user_buffer_options.before_register_callback) {
int before_result = meta_request->user_buffer_options.before_register_callback(meta_request->user_data);
AWS_LOGF_DEBUG(AWS_LS_S3_RDMA, "id=%p Run before register function", (void *)manager);
if (before_result != AWS_OP_SUCCESS) {
AWS_LOGF_ERROR(
AWS_LS_S3_META_REQUEST,
"id=%p Part %u: Before register function failed (result=%d)",
(void *)meta_request,
request->part_number,
before_result);
return before_result;
}
}

/* Register buffer with RDMA provider */
int register_result = aws_s3_rdma_provider_register_memory(manager->rdma_provider, buffer, buffer_size);
Expand Down