Repository navigation
fix(tags): unblock production D1 migration for suggestions - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CASE … ENDexpressions in migration0006_luxuriant_boomer.sqlwith parentheses.incomplete input: SQLITE_ERROR [7500]seen in the production deployment. Cloudflare's D1 SQL splitter has a documented issue with unparenthesizedSELECT CASE … ENDinside triggers; the trigger logic and limits are unchanged.Verification
0000through0006to a fresh temporary local D1 database with Wrangler 4.123.0.pnpm run build,pnpm run format:check, andgit diff --checkpassed.Release note
The prior production run stopped at migration
0006, before Worker deployment. After merging this PR intoprod, the deployment workflow should retry the pending migration automatically before deploying. Remote D1 parsing cannot be verified from local tests alone; check that the migration and deploy steps both complete successfully. Keep the tag-suggestion switch disabled until the deployed endpoint and quota accounting are smoke-tested.