Skip to content

YOU FOOLS I WON THE CONTEST #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 24, 2025
Merged

YOU FOOLS I WON THE CONTEST #6328

merged 14 commits into from
Apr 24, 2025

Conversation

Irev-Dev
Copy link
Contributor

@Irev-Dev Irev-Dev commented Apr 15, 2025

I'm trying to get the tone right this time.

like why you being so weird about the win kurt

@Irev-Dev Irev-Dev requested review from jessfraz, jgomez720 and a team April 15, 2025 12:50
Copy link

qa-wolf bot commented Apr 15, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 24, 2025 6:10am

@jtran
Copy link
Contributor

jtran commented Apr 16, 2025

Any updates to samples need #6338. Or you can run the commands and add them to your PR manually.

@Irev-Dev
Copy link
Contributor Author

Thanks, I just cherry picked your commit.

@jtran
Copy link
Contributor

jtran commented Apr 16, 2025

Sorry, but I don't think that will work because now it detects changes outside of kcl-samples, and now you have to update and push them manually.

@Irev-Dev
Copy link
Contributor Author

I did kinda figure that after I wrote that comment, just pushed the changes.

@Irev-Dev
Copy link
Contributor Author

still failed 🤷

@jtran
Copy link
Contributor

jtran commented Apr 16, 2025

I might still be missing a command. I can try to fix this up tomorrow.

@jtran
Copy link
Contributor

jtran commented Apr 16, 2025

Pushed fixes.

Also, you might want to update cargo insta to v1.42.2. I use cargo install cargo-insta, but there are other options: https://insta.rs/docs/cli/

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.04%. Comparing base (1628ea8) to head (7b75f97).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6328   +/-   ##
=======================================
  Coverage   85.03%   85.04%           
=======================================
  Files         108      108           
  Lines       46145    46145           
=======================================
+ Hits        39241    39242    +1     
+ Misses       6904     6903    -1     
Flag Coverage Δ
rust 85.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Irev-Dev Irev-Dev enabled auto-merge (squash) April 24, 2025 05:58
@Irev-Dev Irev-Dev merged commit 2956f9e into main Apr 24, 2025
39 of 40 checks passed
@Irev-Dev Irev-Dev deleted the kurt-dodec branch April 24, 2025 06:08
franknoirot pushed a commit that referenced this pull request Apr 24, 2025
* dodec

* fmt

* comment

* Update kcl-samples simulation test output

* Update kcl-samples simulation test output

* Fix so that just commands regenerate ast output

* overwrite

* Update just command to include manifest

* Update generated output

* merge main post

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants