-
Notifications
You must be signed in to change notification settings - Fork 75
YOU FOOLS I WON THE CONTEST #6328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Any updates to samples need #6338. Or you can run the commands and add them to your PR manually. |
Thanks, I just cherry picked your commit. |
Sorry, but I don't think that will work because now it detects changes outside of |
I did kinda figure that after I wrote that comment, just pushed the changes. |
still failed 🤷 |
I might still be missing a command. I can try to fix this up tomorrow. |
Pushed fixes. Also, you might want to update |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6328 +/- ##
=======================================
Coverage 85.03% 85.04%
=======================================
Files 108 108
Lines 46145 46145
=======================================
+ Hits 39241 39242 +1
+ Misses 6904 6903 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* dodec * fmt * comment * Update kcl-samples simulation test output * Update kcl-samples simulation test output * Fix so that just commands regenerate ast output * overwrite * Update just command to include manifest * Update generated output * merge main post --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan Tran <[email protected]>
I'm trying to get the tone right this time.