Skip to content

Remove pixel color checks from manual edit tests #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jacebrowning
Copy link
Contributor

@jacebrowning jacebrowning commented Apr 16, 2025

The pixel color checks are only used for waiting. The tests check for the expected code so that should be sufficient.


npm run test:playwright:electron -- --grep="manual edits during sketch mode" --repeat-each=10

Before: https://test-analysis-bot.hawk-dinosaur.ts.net/projects/KittyCAD/modeling-app/tests/461?branch=main

After: https://test-analysis-bot.hawk-dinosaur.ts.net/projects/KittyCAD/modeling-app/tests/461?branch=fix-manual-edits

@jacebrowning jacebrowning self-assigned this Apr 16, 2025
Copy link

qa-wolf bot commented Apr 16, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 16, 2025 6:39pm

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (e955e78) to head (3cb9f78).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6349   +/-   ##
=======================================
  Coverage   84.96%   84.97%           
=======================================
  Files         108      108           
  Lines       45599    45599           
=======================================
+ Hits        38745    38747    +2     
+ Misses       6854     6852    -2     
Flag Coverage Δ
rust 84.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacebrowning
Copy link
Contributor Author

See #6365

@jacebrowning jacebrowning deleted the fix-manual-edits branch May 2, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant