Skip to content

Hole point-and-click: first pass with current command palette #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 93 commits into
base: main
Choose a base branch
from
Open

Hole point-and-click: first pass with current command palette #8565

wants to merge 93 commits into from

Conversation

@pierremtb
Copy link
Contributor

@pierremtb pierremtb commented Oct 15, 2025 •
edited
Loading

Fixes #7626

This is a first pass at wiring up the create & edit flows with the current UI elements available. The work being done at #8522 will greatly improve the UI for Hole when it ships, but we don't technically need to wait on that.

Caveat:

Creating a Hole on the result of a Hole doesn't work yet, see #8616. Don't think we should block this from shipping as Experimental though.

Demo:

Screen.Recording.2025-10-23.at.6.04.11.PM.mov

Early notes

@vercel
Copy link

vercel bot commented Oct 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Oct 23, 2025 10:18pm

@pierremtb pierremtb changed the title WIP: Hole wizard point-and-click side Hole point-and-click: first pass Oct 15, 2025
@pierremtb pierremtb mentioned this pull request Oct 22, 2025
Closed
@pierremtb pierremtb mentioned this pull request Oct 22, 2025
Merged
@pierremtb pierremtb changed the base branch from main to pierremtb/issue8636-race-condition-exp-features October 22, 2025 17:03
pierremtb added a commit that referenced this pull request Oct 23, 2025
@pierremtb
Fix race condition with setExperimentalFeatures (#8637)
ff1edf1 
* Fix race condition with setExperimentalFeatures
Closes #8636, needed for #8565

* Move to a codemod file, do proper dep injection, add unit tests

* Lint

* Lint
Base automatically changed from pierremtb/issue8636-race-condition-exp-features to main October 23, 2025 14:53
@pierremtb pierremtb marked this pull request as ready for review October 23, 2025 22:07
@pierremtb pierremtb requested a review from a team as a code owner October 23, 2025 22:07
franknoirot pushed a commit that referenced this pull request Oct 24, 2025
@pierremtb @franknoirot
Fix race condition with setExperimentalFeatures (#8637)
2f4efe1 
* Fix race condition with setExperimentalFeatures
Closes #8636, needed for #8565

* Move to a codemod file, do proper dep injection, add unit tests

* Lint

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hole point-and-click side

1 participant

@pierremtb