Dark mode: use dark edges #8566
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
src/network/connectionManager.ts
Outdated
Comment on lines
454
to
456
| type: 'set_default_system_properties', | ||
| color: getThemeColorForEngine(opposingTheme), | ||
| color: getVolumeColorForEngine(opposingTheme), |
There was a problem hiding this comment.
There appears to be an inconsistency in the implementation. Line 462 uses getVolumeColorForEngine(opposingTheme) while lines 464-465 use getEdgeColorForEngine(opposingTheme). To properly implement dark edges as intended by this PR, line 462 should also use getEdgeColorForEngine instead of getVolumeColorForEngine.
Suggested change
| type: 'set_default_system_properties', | |
| color: getThemeColorForEngine(opposingTheme), | |
| color: getVolumeColorForEngine(opposingTheme), | |
| type: 'set_default_system_properties', | |
| color: getEdgeColorForEngine(opposingTheme), |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
adamchalmers
force-pushed
the
achalmers/darkmode-dark-edges
branch
from
f31cd43 to
f6e3a60
Compare
|
@adamchalmers I'm going to put this back in draft since it's blocked. I think you can also revert that automated "Update snapshots" commit and merge in the latest |
|
Thanks Jace! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few suggestions that the light edges look weird in dark mode. Let's make the edges dark, even in dark mode.
Edges in sketch mode are still white:
but unclosed edges drawn by the engine are black, and don't look good.