fix: properly setting diagnostic errors when opening and closing code mirror

src/components/ModelingSidebar/ModelingPanes/KclEditorPane.tsx

@@ -19,7 +19,7 @@ import {
   indentOnInput,
   syntaxHighlighting,
 } from '@codemirror/language'
-import { diagnosticCount, lintGutter, lintKeymap } from '@codemirror/lint'
+import { lintGutter, lintKeymap } from '@codemirror/lint'
 import { highlightSelectionMatches, searchKeymap } from '@codemirror/search'
 import type { Extension } from '@codemirror/state'
 import { EditorState, Prec, Transaction } from '@codemirror/state'
@@ -79,7 +79,6 @@ export const KclEditorPane = () => {
     return () => {
       kclEditorActor.send({ type: 'setKclEditorMounted', data: false })
       kclEditorActor.send({ type: 'setLastSelectionEvent', data: undefined })
-      kclManager.diagnostics = []
     }
   }, [])
 
@@ -207,17 +206,8 @@ export const KclEditorPane = () => {
 
             // Update diagnostics as they are cleared when the editor is unmounted.
             // Without this, errors would not be shown when closing and reopening the editor.
-            kclManager
-              .safeParse(codeManager.code)
-              .then(() => {
-                // On first load of this component, ensure we show the current errors
-                // in the editor.
-                // Make sure we don't add them twice.
-                if (diagnosticCount(_editorView.state) === 0) {
-                  kclManager.setDiagnosticsForCurrentErrors()
-                }
-              })
-              .catch(reportRejection)
+            // We do this because we trust the cache on the rust side to not recompute all the engine commands
+            kclManager.executeCode().catch(reportRejection)
           }}
         />
       </div>