Skip to content

feat(KeyboardShortcut): Add left and right arrow to cycle through images #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lchauvin
Copy link
Contributor

Related to #610

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e92dd52
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6707ff3f45f618000803180a
😎 Deploy Preview https://deploy-preview-611--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax self-requested a review June 27, 2024 18:27
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Thanks!

@floryst
Copy link
Collaborator

floryst commented Jun 27, 2024

This does have an issue where not-yet reconstructed DICOM images aren't included in the cycling. I'm unifying the image list in #606, which should make this easier.

@lchauvin
Copy link
Contributor Author

Has the list of images been unified ?

@PaulHax
Copy link
Collaborator

PaulHax commented Apr 28, 2025

@lchauvin #606 added an imageCacheStore which holds image IDs for DICOM and other image types, even as they are loaded. So the arrow keys probably want to loop through the imageCacheStore.imageIds array.

@floryst
Copy link
Collaborator

floryst commented Apr 29, 2025

I've given this some thought, so here are some ideas I had for this feature:

  • the patient studies + images sidebar should have a backing store for it, which defines the order of the seen images. The order of the images in the image cache store might not be particularly useful, since the order still might not be what is visually seen in the sidebar
  • The left/right arrow cycles will use this backing store to select the next image

@PaulHax PaulHax mentioned this pull request May 2, 2025
4 tasks
@lchauvin
Copy link
Contributor Author

lchauvin commented May 7, 2025

Should I wait for the backing store before making any modification ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants