feat!: Update to Node 14 - #127
Open
ZigaStrgar wants to merge 2 commits into
Open
Conversation
* Node 14 minimum version * Updated Babel dependencies * Updated imagemin dependencies * Moved all types to devDependencies * Changed let to const
Signed-off-by: ZigaStrgar <ziga.strgar@gmail.com>
Author
|
Hey @Klathmon, would you like to check this, and give some feedback/pointers if something is missing? 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Older version was using dependencies with some security vulnerabilities, so by updating dependencies those were addressed along with updating the minimum version of NodeJS, as the package was unmaintained for a while.
ToDo
imageminto remove security vulnerabilitiesdevDependencieslettoconstimagemindependencies are ESM only I didn't update them to the latest version as it would break the code using it. As Babel is not ESM only yet.