add call declarations to digital-carbon #165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psparacino
force-pushed
the
tufnel/optimize-sync-with-calls-declaration
branch
from
50da071 to
49d74e0
Compare
psparacino
force-pushed
the
tufnel/optimize-sync-with-calls-declaration
branch
from
49d74e0 to
2085297
Compare
psparacino
force-pushed
the
tufnel/optimize-sync-with-calls-declaration
branch
from
853ef94 to
c112d62
Compare
|
Is this still worth doing? What did you find re: speed? |
I tested two new deployments and the one with the call declarations actually took longer(*) to sync than a non-call manifest. No idea why and discord support had no ideas other. This is either a newer or not understood feature so I kind of abandoned it after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires an updated specVersion to 1.2.0
Possible in this spec version to declare calls in the manifest: https://thegraph.com/docs/en/cookbook/avoid-eth-calls/#reducing-the-runtime-overhead-of-eth_calls
These calls can only have params prefixed with event (.address or .params.x). The calls do not run sequentially in the handler, but are performed concurrently and stored in memory until needed by the handler.
More of an experimental PR to see if this can marginally increase the speed.