fix: produced array may have side-effect to given args #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some condition that given args has an array, for example:
In general programming languages, it excepts
[]interface{}{[]interface{}{1, 2, 3}, 1.0, 2.0, 3.0}
, but actually, it will return[]interface{}{1, 2, 3, 1.0, 2.0, 3.0}
with side-effects and may cause data race when multi-threads executing even expression is stateless.The root cause is
separatorStage
using contextless left production rule, so no way to check the slice type left value is produced byseparatorStage
or user given parameter. There is a simple to check is using type alias to change the etype of produced slice.