fix(server): include daily_allocations in TaskFieldsBase server response model - #1172
Open
amir-rezaei wants to merge 1 commit into
Open
Conversation
Owner
|
Confirmed the underlying bug — Before merging, please add tests. This PR is a one-line field addition with no coverage, and #1135 explicitly asks for the drift guard rather than just the field:
Verified locally against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #1135 by adding
daily_allocations: dict[str, float]toTaskFieldsBaseinpackages/taskdog-server/src/taskdog_server/api/models/responses.py.Details
TaskFieldsBaseomitteddaily_allocations, causing FastAPI response serialization of write operations (TaskOperationResponse,UpdateTaskResponse) to dropdaily_allocations.daily_allocationsto an empty dictionary{}after create, update, or lifecycle calls.daily_allocationsensures full feature parity and complete data round-tripping between the server response models and client DTOs.