Skip to content

fix(ci): audit project dependencies in security scan job - #1175

Closed
amir-rezaei wants to merge 1 commit into
Kohei-Wada:mainfrom
amir-rezaei:fix/ci-security-scan-dependencies
Closed

fix(ci): audit project dependencies in security scan job#1175
amir-rezaei wants to merge 1 commit into
Kohei-Wada:mainfrom
amir-rezaei:fix/ci-security-scan-dependencies

Conversation

@amir-rezaei

Copy link
Copy Markdown
Contributor

Description

This PR resolves issue #1150 by updating the Security Scan job in .github/workflows/ci.yml to audit project workspace dependencies instead of pip-audit's isolated tool environment.

Details

  • Replaces uv sync --all-extras --dev with uv sync --all-packages --all-extras --dev so all workspace packages and dependencies are installed.
  • Replaces uv tool run pip-audit with uv run --no-sync pip-audit so pip-audit scans the project environment rather than its own ephemeral tool environment.

@Kohei-Wada

Copy link
Copy Markdown
Owner

Thanks for the contribution, but CI is failing on this PR (Security Scan), and no fix has been pushed.

Closing to keep the review queue actionable. Please feel free to reopen once:

  • all required checks pass on your branch, and
  • the change is covered by tests that pass locally (make check && make test).

A PR that fails its own package's test suite can't be reviewed on its merits, so please verify locally before opening.

@Kohei-Wada Kohei-Wada closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants