Skip to content

fix(tui): pass active status and tag filters to list_tasks during TUI export - #1180

Closed
amir-rezaei wants to merge 1 commit into
Kohei-Wada:mainfrom
amir-rezaei:fix/tui-export-respect-filters
Closed

fix(tui): pass active status and tag filters to list_tasks during TUI export#1180
amir-rezaei wants to merge 1 commit into
Kohei-Wada:mainfrom
amir-rezaei:fix/tui-export-respect-filters

Conversation

@amir-rezaei

Copy link
Copy Markdown
Contributor

Description

This PR resolves part of issue #1144 by ensuring the TUI export command in packages/taskdog-ui/src/taskdog/tui/commands/export.py passes active status and tag filters to api_client.list_tasks.

Details

  • Previously, ExportCommand retrieved all tasks with only include_archived=self.context.state.show_archived, ignoring active filters applied in the TUI.
  • This PR retrieves active status_filter and tag_filter from state to filter exported tasks accordingly.

@Kohei-Wada

Copy link
Copy Markdown
Owner

Thanks for the contribution, but CI is failing on this PR (Test (taskdog-ui)), and no fix has been pushed.

Closing to keep the review queue actionable. Please feel free to reopen once:

  • all required checks pass on your branch, and
  • the change is covered by tests that pass locally (make check && make test).

A PR that fails its own package's test suite can't be reviewed on its merits, so please verify locally before opening.

@Kohei-Wada Kohei-Wada closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants