fix(tui): pass active status and tag filters to list_tasks during TUI export - #1180
Closed
amir-rezaei wants to merge 1 commit into
Closed
fix(tui): pass active status and tag filters to list_tasks during TUI export#1180amir-rezaei wants to merge 1 commit into
amir-rezaei wants to merge 1 commit into
Conversation
Owner
|
Thanks for the contribution, but CI is failing on this PR (Test (taskdog-ui)), and no fix has been pushed. Closing to keep the review queue actionable. Please feel free to reopen once:
A PR that fails its own package's test suite can't be reviewed on its merits, so please verify locally before opening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves part of issue #1144 by ensuring the TUI export command in
packages/taskdog-ui/src/taskdog/tui/commands/export.pypasses active status and tag filters toapi_client.list_tasks.Details
ExportCommandretrieved all tasks with onlyinclude_archived=self.context.state.show_archived, ignoring active filters applied in the TUI.status_filterandtag_filterfrom state to filter exported tasks accordingly.