Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference: Gateway logs #458

Merged
merged 8 commits into from
Feb 18, 2025
Merged

Reference: Gateway logs #458

merged 8 commits into from
Feb 18, 2025

Conversation

cloudjumpercat
Copy link
Contributor

@cloudjumpercat cloudjumpercat commented Feb 14, 2025

Description

Fixes #367

Preview Links

https://deploy-preview-458--kongdeveloper.netlify.app/gateway/logs/

Stub pages

Reviewer notes

  • if_version isn't supported, so the table looks a bit odd, just an FYI. I'm leaving the Liquid tags in for findability to fix this when we have the support.
  • What do you think of the AI Gateway logs stuff here? I figured it belonged here in the spirit of every page is page one.

Checklist

  • Every page is page one.
  • Tested how-to docs. If not, note why here. (I tested all APIs. I wasn't able to get a 200 on the control plane one since I didn't have anything in Gateway hybrid, and I don't think that one would work for Konnect?)
  • All pages contain metadata.
  • Updated sources.yaml. For more info, review track docs changes
  • Any new docs link to existing docs.
  • All autogenerated instructions render correctly (API, decK, Konnect, Kong Manager).
  • Style guide (capitalized gateway entities, placeholder URLs) implemented correctly.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit c3726b0
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/67b37485d7e13200085ac16d
😎 Deploy Preview https://deploy-preview-458--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat marked this pull request as ready for review February 14, 2025 22:22
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner February 14, 2025 22:22
@lmilan lmilan self-requested a review February 17, 2025 15:24
Copy link
Contributor

@lmilan lmilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think the description for crit needs to be rephrased
  • In the table with the API endpoints, I would replace notice with {log_level} to make it clearer
  • I think it makes sense to have the AI Gateway logs on this page!

@cloudjumpercat cloudjumpercat merged commit a0683ba into main Feb 18, 2025
10 checks passed
@cloudjumpercat cloudjumpercat deleted the gateway-logs branch February 18, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway logs reference
2 participants