feat(konnect): add KongCredentialSecretReconciler to reconcile consumer Secrets with basic-auth credentials and create KongCredentialBasicAuth in response
#1120
+1,445
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
credentials-basic-auth
branch
4 times, most recently
from
ddddee8 to
50a7e26
Compare
pmalek
force-pushed
the
credentials-basic-auth
branch
2 times, most recently
from
4a3e524 to
72501c6
Compare
pmalek
changed the title
KongCredentialBasicAuth in response
randmonkey
reviewed
Feb 7, 2025
pmalek
force-pushed
the
credentials-basic-auth
branch
from
72501c6 to
380ee46
Compare
mlavacca
reviewed
Feb 7, 2025
pmalek
commented
Feb 10, 2025
randmonkey
reviewed
Feb 11, 2025
…er Secrets and create Credential resources in response
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
…tial secrets reconciler
pmalek
force-pushed
the
credentials-basic-auth
branch
from
9eb2180 to
b0e50d6
Compare
randmonkey
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds
KongCredentialSecretReconcilerwhich reconcilesSecrets used asKongConsumers'credentialsand managedKongCredentialBasicAuthresources in response.For each
KongConsumercredential this reconciler will create a corresponding credential resource.Which issue this PR fixes
Part of #618
Closes #1122
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes